Skip to content

fix(export): prevent static render hangs#62

Merged
xjdr-noumena merged 3 commits into
mainfrom
fix/export-feedback-hang-49
Jul 2, 2026
Merged

fix(export): prevent static render hangs#62
xjdr-noumena merged 3 commits into
mainfrom
fix/export-feedback-hang-49

Conversation

@xjdr-noumena

@xjdr-noumena xjdr-noumena commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes the /export hang portion of #49 and updates /feedback to target the real Noumena collector route.

  • fixes the headless Ink/static-render lifecycle race that caused /export to hang before writing a file or showing the export dialog
  • fixes the non-TTY renderer import path exposed by the static-render regression (cellAt)
  • lazy-loads ExportDialog so /export <filename> does not import dialog/model UI modules
  • changes /feedback submission from the legacy /api/claude_cli_feedback path to /api/ncode_feedback
  • keeps missing collector routes fail-closed in the client; GitHub issue drafting remains the post-submit/done flow, not a substitute for collector persistence
  • hardens the existing toolPromptRouting model mock so later tests still see unmocked model exports
  • adds regressions for static render completion, /export <filename>, and feedback collector request shape/fail-closed behavior

Backend note: the matching internal api/ change exposes authenticated POST /api/ncode_feedback and the legacy POST /api/claude_cli_feedback alias through APIFE and stores feedback in the existing ncode_logs Scribe category before returning feedback_id.

Validation

Focused #49 regressions:

/home/xjdr/.bun/bin/bun test \
  src/utils/staticRender.test.tsx \
  src/commands/export/export.test.tsx \
  src/components/Feedback.submit.test.ts

Result: 4 pass, 0 fail.

Model-mock ordering regression slice:

/home/xjdr/.bun/bin/bun test \
  src/tools/toolPromptRouting.test.ts \
  src/commands/export/export.test.tsx

Result: 7 pass, 0 fail.

Contracts:

PATH="$HOME/.bun/bin:$PATH" timeout 120s /home/xjdr/.bun/bin/bun run test:contracts

Result from previous revision of this PR: 242 pass, 0 fail. After the latest feedback-route correction, focused regressions above passed; full contracts should rerun in CI/package smoke.

Package smoke:

PATH="$HOME/.bun/bin:$PATH" timeout 180s /home/xjdr/.bun/bin/bun run test:package-smoke

Result from previous revision of this PR: passed. Security audit OK; native probe OK with documented sharp-fallback image mode.

Diff check:

git diff --check

Result from previous revision of this PR: passed.

@xjdr-noumena xjdr-noumena merged commit 2455f58 into main Jul 2, 2026
3 checks passed
@xjdr-noumena xjdr-noumena deleted the fix/export-feedback-hang-49 branch July 2, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant