fix(updater): use public release sources#61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the public native updater source for #46.
NCODE_NATIVE_PACKAGE_URL/MACRO.NATIVE_PACKAGE_URLas the explicit binary-repo override for public GCS or internal-only bucketsInternal deployments should set
NCODE_NATIVE_PACKAGE_URLto their internal bucket. There is no internal Artifactory fallback.Validation
Focused updater/native installer tests:
Result:
6 pass, 0 failfor the two new/changed test files;packageManagers.test.tsis absent in this checkout.Contracts:
Result:
238 pass, 0 fail.Package smoke:
Result: passed. Security audit OK; native probe OK with documented
sharp-fallbackimage mode.Diff check:
Result: passed.
Updater residue check:
rg -n "artifactory|Artifactory|ARTIFACTORY|claude-code-dist|undefined@latest|npm view undefined|MACRO.NATIVE_PACKAGE_URL}@|NATIVE_PACKAGE_URL}@" \ src/utils/nativeInstaller src/utils/autoUpdater.ts src/components/PackageManagerAutoUpdater.tsx src/components/AutoUpdater.tsx src/cli/update.ts build .github README.md OSS_BUILD.md package.jsonResult: no matches in the targeted updater surfaces.
Closes #46.