fix(security): sanitize Mermaid SVG rendering - #165
Draft
16th-admin wants to merge 3 commits into
Draft
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
🤖 Codex-Style Code Review by OpenCode
|
Contributor
🤖 Codex-Style Code Review by OpenCode
|
1 similar comment
Contributor
🤖 Codex-Style Code Review by OpenCode
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sanitize both Mermaid SVG output and parser-generated HTML with DOMPurify before inserting them into the document.
Root cause
The rich-text renderer inserted generated markup directly into the DOM, which triggered CodeQL's DOM-text-to-HTML alert.
Validation
src/services/pltxt2htm/advancedParser.ts: 0 errorsgit diff --checkThis is intentionally separate from the ESLint refactor in #147.