Skip to content

Use combined rel+abs tolerance for line-segment test in test-prism #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevengj merged 2 commits into from
Jun 26, 2026
Merged

Use combined rel+abs tolerance for line-segment test in test-prism #93

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6345393
test-prism: use combined rel+abs tolerance for line-segment test
Luochenghuang Jun 26, 2026
ff6d3fa
Apply suggestion from @stevengj
stevengj Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions utils/test-prism.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,10 +375,12 @@ int test_line_segment_intersection(geometric_object the_block, geometric_object

double sblock = intersect_line_segment_with_object(p, d, the_block, a, b);
double sprism = intersect_line_segment_with_object(p, d, the_prism, a, b);
if (fabs(sblock - sprism) > 1.0e-6 * fmax(fabs(sblock), fabs(sprism))) num_failed++;
double diff = fabs(sblock - sprism);
double tol = 1.0e-5 * vector3_norm(size);
if (diff > tol) num_failed++;

if (f) {
int success = fabs(sblock - sprism) <= 1.0e-6 * fmax(fabs(sblock), fabs(sprism));
int success = diff <= tol;
#pragma omp critical(test_prism_log)
{
fprintf(f, " %e %e %s\n", sblock, sprism, success ? "success" : "fail");
Expand Down
Loading