Skip to content

Respect STDEXEC_ENABLE_LIBDISPATCH option#2118

Open
fallintoplace wants to merge 1 commit into
NVIDIA:mainfrom
fallintoplace:fix/libdispatch-option-respected
Open

Respect STDEXEC_ENABLE_LIBDISPATCH option#2118
fallintoplace wants to merge 1 commit into
NVIDIA:mainfrom
fallintoplace:fix/libdispatch-option-respected

Conversation

@fallintoplace

Copy link
Copy Markdown

Summary

Make the Darwin libdispatch compile definition follow STDEXEC_ENABLE_LIBDISPATCH instead of defining it unconditionally whenever CMake runs on Darwin. This lets users explicitly configure with -DSTDEXEC_ENABLE_LIBDISPATCH=OFF even when dispatch/dispatch.h is present.

Testing

  • cmake -S . -B build-libdispatch-off -G Ninja -DSTDEXEC_ENABLE_LIBDISPATCH=OFF
  • confirmed build-libdispatch-off/compile_commands.json does not contain STDEXEC_ENABLE_LIBDISPATCH
  • cmake --build build-libdispatch-off --target test.exec -j 8
  • ./build-libdispatch-off/test/exec/test.exec
  • cmake -S . -B build -G Ninja
  • confirmed build/compile_commands.json contains STDEXEC_ENABLE_LIBDISPATCH with the default Darwin option
  • cmake --build build --target test.exec -j 8
  • ./build/test/exec/test.exec "*libdispatch*"
  • ./build/test/exec/test.exec

@copy-pr-bot

copy-pr-bot Bot commented Jun 18, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant