-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Unbind cudf::size_type from offsets used by list columns #23607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
6d369ec
b7f310a
9a5365a
3d4ca87
c1d1c53
dd326b2
598ae02
80e37ef
4c608c8
ebb3690
0f2535b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -323,8 +323,8 @@ std::unique_ptr<column> md5(table_view const& input, | |||||||||
| if (data_col.type().id() == type_id::LIST) { | ||||||||||
| CUDF_UNREACHABLE("Nested list unsupported"); | ||||||||||
| } | ||||||||||
| auto const offset_begin = offsets.element<size_type>(row_index); | ||||||||||
| auto const offset_end = offsets.element<size_type>(row_index + 1); | ||||||||||
| auto const offset_begin = offsets.element<int32_t>(row_index) + col.offset(); | ||||||||||
| auto const offset_end = offsets.element<int32_t>(row_index + 1) + col.offset(); | ||||||||||
|
Comment on lines
+326
to
+327
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe
Suggested change
|
||||||||||
| cudf::type_dispatcher<dispatch_storage_type>( | ||||||||||
| data_col.type(), ListHasherDispatcher(&hasher, data_col), offset_begin, offset_end); | ||||||||||
| } else { | ||||||||||
|
|
||||||||||
Uh oh!
There was an error while loading. Please reload this page.