Stop inspecting atomic_ref::fetch_or in Bloom filter checks - #832
Closed
PointKernel wants to merge 1 commit into
Closed
Stop inspecting atomic_ref::fetch_or in Bloom filter checks#832PointKernel wants to merge 1 commit into
atomic_ref::fetch_or in Bloom filter checks#832PointKernel wants to merge 1 commit into
Conversation
PointKernel
added
type: bug
Collaborator
|
Superseeded by #833 |
PointKernel
pushed a commit
that referenced
this pull request
Aug 14, 2026
This PR replaces the user-specified `Word` type in `bloom_filter_policy` with a `WordBytes` parameter supporting 4- and 8-byte words. The policy selects the corresponding native `atomicOr` type internally, preventing users from supplying incompatible word types and removing the associated validation and conversion machinery. By removing the stale `cuda::atomic_ref::fetch_or` inspection, this also fixes the cuCollections compatibility issue exposed by [NVIDIA/cccl#10727](NVIDIA/cccl#10727) and supersedes #832.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per NVIDIA/cccl#10727,
bloom_filter_implno longer takes the address ofcuda::atomic_ref::fetch_orto validateword_type. That check depends on the exact standard-library function form and breaks when P3323R1 is backported with constrained member templates. Since the Bloom filter uses nativeatomicOr, this PR checks the actual requirement instead: an integral 4- or 8-byte word type.Validated against the current head of NVIDIA/cccl#10727; all 46 Bloom-filter test cases and 122 assertions pass.