refactor(switchyard): remove built-in service integration - #595
Draft
bbednarski9 wants to merge 1 commit into
Draft
refactor(switchyard): remove built-in service integration#595bbednarski9 wants to merge 1 commit into
bbednarski9 wants to merge 1 commit into
Conversation
Signed-off-by: Bryan Bednarski <bbednarski@nvidia.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
License DiffCompared against Lockfile license changesLockfile License ChangesRustAdded
Removed
Updated/Changed
NodeAdded
Removed
Updated/Changed
PythonAdded
Removed
Updated/Changed
Status output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Remove the built-in, service-backed Switchyard integration after its supported behavior moved to the external
nvidia.switchyardnative dynamic plugin.Details
nemo-relay-switchyardworkspace crate, CLIswitchyardCargo feature, static component registration/editor support, service process E2E, and service-launching examples.switchyard-translationfrom Relay's dependency graph and crates.io release inventory.[[components]] kind = "switchyard"configuration with migration guidance for thenvidia.switchyardnative API v2 plugin.[[plugins.dynamic]].Cargo.lockandATTRIBUTIONS-Rust.md.This PR is intentionally independent from the ABI implementation branch, but must not merge before:
switchyard-nemo-relay-pluginbundle.The external plugin has already passed fake-provider process E2E and live Inference Hub routing through the ABI v2 branch. The live run produced 12 routing-requested and 12 routing-decision marks across two models in Phoenix project
nemo-relay-switchyard-dynamic-plugin-20260730.Validation:
cargo check -p nemo-relay-cli --all-targetscargo test -p nemo-relay-cli --lib plugins::tests::editor_cargo test -p nemo-relay-cli --lib plugins::tests::component_cargo test -p nemo-relay-cli --lib server::tests::serve_listener_activates_cargo test -p nemo-relay-cli --lib plugins::tests::validate_config_rejects_removed_switchyard_component_with_migration_guidance -- --exactcargo clippy -p nemo-relay-cli --all-targets -- -D warningscargo deny checkcargo fmt --all -- --checkThe unrestricted full CLI unit binary currently reports unrelated failures caused by user-level configuration leaking into configuration assertions and the resulting poisoned global test lock. The focused code paths changed here pass independently.
Breaking change: Relay no longer ships or publishes the built-in
nemo-relay-switchyardservice integration. Existing service configuration must migrate to the external native API v2 plugin.Where should the reviewer start?
Start with
crates/cli/src/server/mod.rsfor the legacy-configuration migration error, then reviewdocs/configure-plugins/switchyard/about.mdxfor the operator migration path. The remaining changes remove the old crate and its build, release, test, and example surfaces.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)