Added DISABLE_DYNAMIC_RATE_LIMITING compilation toggle#207
Conversation
|
Thank you for the contribution, I really appreciate the help There’s just a few things missing:
Again, thank you for your help. If you have any questions don't mind asking me. I will try to merge it ASAP. |
|
Hello, thank you very much for making a detailed comment on the parts I've overlooked. It was really helpful since I'm very new to "contribution" and network related projects. Right now I'm trying to work on the last point, about removing the 2 variables called Apologies if asking the obvious: should I wrap the 2 stated variables in #ifndef DISABLE_DYNAMIC_RATE_LIMITING like I did for other parts? If so my code is ready to push online. Thank you in advance for your patience! |
|
Don’t apologize for asking simple questions, even I am kinda lost in the codebase since it’s big and i’m reworking some things in another branch. Sorry for not pointing out everything, I tried to help ASAP, because I was at work while responding. Just looked at the commit containing implementation of rate limiting and this should be all of it. Both fields (last_chunks_received_number and last_index_checked) are only for the sole reason of rate limiting, so please wrap every usage of them in the #ifndef. If you need any help, just let me know. If tests pass without problems, I will merge it. I’m working till 11PM UTC+2, so I will probably not respond till tomorrow. |
Deleted mistakenly uploaded build.log file
|
Thank you very much for giving even more detailed instructions and for the encouragement! I couldn't allocate time before 11PM today due to personal reasons. I would be glad if you could take a look at it tomorrow for any changes that I might need to make or missed from previous comment. For the latest commits I've
|
Added DISABLE_DYNAMIC_RATE_LIMITING which should make the library use less CPU, costing only a tiny bit slow sending speed as described.