fix(agent-core): refresh MCP tools on list changes#1350
Open
Pluviobyte wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 63654b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #1138
Problem
See linked issue. Connected MCP servers can advertise
tools.listChanged, but the active session kept the startup tool registry afternotifications/tools/list_changed.What changed
McpConnectionManagerwhile ignoring stale reconnect attempts and preserving existing tools on refresh errors.Validation:
pnpm -C packages/agent-core exec vitest run test/mcp/connection-manager.test.tspnpm --filter @moonshot-ai/agent-core run typecheckpnpm exec oxlint --type-aware packages/agent-core/src/mcp/client-shared.ts packages/agent-core/src/mcp/client-stdio.ts packages/agent-core/src/mcp/client-http.ts packages/agent-core/src/mcp/client-sse.ts packages/agent-core/src/mcp/connection-manager.ts packages/agent-core/test/mcp/connection-manager.test.ts packages/agent-core/test/mcp/fixtures/dynamic-tools-stdio-server.mjspnpm changeset status --since mainChecklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.