Activate service worker updates immediately - #94
Merged
Conversation
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 30, 2026
…-update Activate service worker updates immediately efef0d2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The inject-manifest service worker claimed clients after activation but never called
skipWaiting(), so an installed update remained waiting until every open tab closed.Impact
Deployed updates can activate while existing tabs remain open instead of leaving users on the previous bundle indefinitely.
Verification
npm test -- src/sw.test.ts(red before the fix, green after)npm test(105 files, 1043 tests)npm run typechecknpm run buildnpm run precommitCloses #65