Override getBiome(ChunkPos chunkPos) in NetherBiomeSourceImpl #266
Open
GlacialSkyfarer wants to merge 1 commit into
Open
Override getBiome(ChunkPos chunkPos) in NetherBiomeSourceImpl #266GlacialSkyfarer wants to merge 1 commit into
GlacialSkyfarer wants to merge 1 commit into
Conversation
… mob spawning in custom nether biomes work. Fixes ModificationStation#265
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on my own mod I found that while in the nether, getBiome(ChunkPos chunkPos) always returns Biome.HELL.
As it turns out, the method being accessed was instead the one from the base FixedBiomeProvider which is not used anywhere else, and thus would always return the vanilla Biome.HELL instead of getting it from the proper provider.
After a quick test this change seems to have resolved the issue.
Fixes #265