Recover the uint64 PG typedef to uint64_t in the catalog#33
Merged
estebanzimanyi merged 1 commit intoJul 8, 2026
Merged
Conversation
The type-recovery pass rewrites PG-vendored types that libclang collapses to int back to their real spelling from the header text. uint64 was absent from the recovery map, so every uint64 parameter and return (the raquet quadbin cell, all *_hash_extended seeds and results, and other uint64 surfaces) appeared as int in the catalog, truncating 64-bit values to 32 bits in the generated bindings. Add uint64 -> uint64_t, mirroring the existing int64 entry and the H3Index and Quadbin entries that already recover to uint64_t, and add a regression test that asserts the bare-uint64 *_hash_extended surface recovers to uint64_t.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A regression test (
test_uint64_recovered) asserts the bare-uint64*_hash_extendedsurface recovers touint64_t, so a future refactor that drops the entry fails CI. Full suite: 148 passed, 14 skipped.