Skip to content

fix: restore desktop composer keyboard navigation - #2037

Merged
crossle merged 2 commits into
mainfrom
fix/desktop-composer-keyboard
Aug 23, 2026
Merged

fix: restore desktop composer keyboard navigation#2037
crossle merged 2 commits into
mainfrom
fix/desktop-composer-keyboard

Conversation

@YeungKC

@YeungKC YeungKC commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • restore macOS multiline caret navigation with Flutter's built-in text editing
  • remove the obsolete app-level IME shortcut workaround
  • prevent conversation navigation shortcuts from claiming a focused multiline editor
  • allow Tab to confirm a valid mention suggestion

Upstream

Tests

  • dart analyze lib/app.dart lib/utils/system/text_input.dart lib/ui/home/conversation/conversation_hotkey.dart lib/ui/provider/mention_provider.dart lib/widgets/mention_panel.dart test/ui/home/conversation/conversation_hotkey_test.dart test/ui/provider/mention_provider_test.dart
  • flutter test test/ui/home/conversation/conversation_hotkey_test.dart
  • flutter test test/ui/provider/mention_provider_test.dart
  • flutter test
  • manual macOS Chinese Pinyin composition check

Restore native multiline caret navigation and mention selection shortcuts on desktop.
@YeungKC
YeungKC force-pushed the fix/desktop-composer-keyboard branch from 2c523d3 to 41c45de Compare August 21, 2026 09:49
@YeungKC
YeungKC marked this pull request as ready for review August 21, 2026 09:52
@crossle
crossle requested a review from boyan01 August 21, 2026 09:54
@YeungKC
YeungKC requested a review from crossle August 21, 2026 09:54
@YeungKC
YeungKC marked this pull request as draft August 21, 2026 10:17
@YeungKC
YeungKC marked this pull request as ready for review August 21, 2026 10:28
@crossle
crossle merged commit 702f1fe into main Aug 23, 2026
3 checks passed
@crossle
crossle deleted the fix/desktop-composer-keyboard branch August 23, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[macOS text input] pinyin candidate view doesn't dismiss itself when the composing text is deleted

3 participants