GEOPY-2994: Support Grid2D in grid_model_merger application#81
Open
domfournier wants to merge 4 commits into
Open
GEOPY-2994: Support Grid2D in grid_model_merger application#81domfournier wants to merge 4 commits into
domfournier wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Grid2D support to the grid_model_merger application by extending mesh conversion utilities and adapting the merge driver to build a 2D output grid when the first selected grid is Grid2D.
Changes:
- Add
Grid2D↔discretize.TensorMeshconversion helpers and extend shared utilities to handle 2D meshes. - Update
grid_model_mergerdriver/options to acceptGrid2Dinputs and emitGrid2Doutputs when appropriate. - Expand test coverage to include
Grid2Dmerge cases and mixed-type merge parameterization.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/run_tests/octree_creation/run_test.py | Adds explicit horizon flags in curve refinement test inputs. |
| tests/run_tests/grid_model_merger_test.py | Adds Grid2D merge tests and parametrized mixed-type merge tests. |
| grid_apps/utils.py | Introduces Grid2D conversion helpers and adapts utilities for 2D discretize meshes. |
| grid_apps/grid_model_merger/options.py | Allows Grid2D selections by converting to discretize meshes via grid2d_to_tensor. |
| grid_apps/grid_model_merger/driver.py | Builds 2D output grids for Grid2D merges and updates global mesh spec handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2994 - Support Grid2D in grid_model_merger application