Skip to content

GEOPY-2994: Support Grid2D in grid_model_merger application#81

Open
domfournier wants to merge 4 commits into
developfrom
GEOPY-2994
Open

GEOPY-2994: Support Grid2D in grid_model_merger application#81
domfournier wants to merge 4 commits into
developfrom
GEOPY-2994

Conversation

@domfournier

@domfournier domfournier commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

GEOPY-2994 - Support Grid2D in grid_model_merger application

Copilot AI review requested due to automatic review settings July 17, 2026 18:39
@github-actions github-actions Bot changed the title GEOPY-2994 GEOPY-2994: Support Grid2D in grid_model_merger application Jul 17, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Grid2D support to the grid_model_merger application by extending mesh conversion utilities and adapting the merge driver to build a 2D output grid when the first selected grid is Grid2D.

Changes:

  • Add Grid2Ddiscretize.TensorMesh conversion helpers and extend shared utilities to handle 2D meshes.
  • Update grid_model_merger driver/options to accept Grid2D inputs and emit Grid2D outputs when appropriate.
  • Expand test coverage to include Grid2D merge cases and mixed-type merge parameterization.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tests/run_tests/octree_creation/run_test.py Adds explicit horizon flags in curve refinement test inputs.
tests/run_tests/grid_model_merger_test.py Adds Grid2D merge tests and parametrized mixed-type merge tests.
grid_apps/utils.py Introduces Grid2D conversion helpers and adapts utilities for 2D discretize meshes.
grid_apps/grid_model_merger/options.py Allows Grid2D selections by converting to discretize meshes via grid2d_to_tensor.
grid_apps/grid_model_merger/driver.py Builds 2D output grids for Grid2D merges and updates global mesh spec handling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/run_tests/grid_model_merger_test.py Outdated
Comment thread tests/run_tests/grid_model_merger_test.py
Comment thread grid_apps/utils.py
Comment thread grid_apps/utils.py Outdated
Comment thread grid_apps/utils.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants