GEOPY-2414: Migrate mesh merger to uijson format#78
Merged
Conversation
github-actions
Bot
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates/introduces the Grid Model Merger workflow to the UIJSON-based app structure and refactors shared mesh utilities to support grid/model merging and refinement.
Changes:
- Added a new
grid_model_mergerapp (options, driver, UIJSON) and accompanying run-tests for block model, octree, and mixed merges. - Refactored mesh conversion/refinement helpers into
grid_apps/utils.py(tensor/block model conversions, TreeMesh refinement helpers, boundary-active-cell detection). - Updated existing drivers/tests to use the new utility entry points and adjusted expected outputs where mesh generation behavior changed.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/utils_test.py | Updates utility tests to new tensor conversion + boundary-active-cell API. |
| tests/run_tests/grid_model_merger_test.py | Adds end-to-end tests for merging block models, octrees, and mixed grids. |
| tests/run_tests/block_2_octree_test.py | Updates expected cell count due to revised refinement/mesh conversion behavior. |
| grid_apps/utils.py | Introduces/refactors tensor/block model conversion, refinement helpers, and boundary-active-cell detection. |
| grid_apps/grid_model_merger/options.py | Adds options model for UIJSON-driven grid/model selections and discretize conversion. |
| grid_apps/grid_model_merger/driver.py | Adds driver implementing grid merge + weighted interpolation onto an output grid. |
| grid_apps/grid_model_merger/init.py | Adds package init for the new app module. |
| grid_apps/block_models/driver.py | Switches BlockModel creation to shared tensor_to_block_model utility. |
| grid_apps/block_model_to_octree/driver.py | Removes duplicated refinement helpers in favor of shared utils implementations. |
| grid_apps-assets/uijson/grid_model_merger.ui.json | Adds UIJSON definition for the Grid Model Merger app. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
benk-mira
requested changes
Jul 9, 2026
Co-authored-by: benk-mira <81254271+benk-mira@users.noreply.github.com>
benk-mira
previously approved these changes
Jul 10, 2026
…ut mesh. Copy entity type
benk-mira
previously approved these changes
Jul 10, 2026
benk-mira
previously approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2414 - Migrate mesh merger to uijson format