GEOPY-2731#213
Open
domfournier wants to merge 40 commits into
Open
Conversation
# Conflicts: # geoapps_utils/base.py
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
for more information, see https://pre-commit.ci
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
GEOPY-2739: Accept BaseUIJson in the start of driver
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates geoapps-utils away from geoh5py.ui_json.InputFile toward the newer geoh5py.ui_json.UIJson API, updating the core driver startup flow, UIJson/group execution utilities, parameter sweep generation/driver logic, and the test suite to match the new serialization and file-writing behavior.
Changes:
- Replace
InputFileusage withUIJsonin runtime code paths (Driver.start,run_uijson_group, ui.json copying, param sweep generation/execution). - Remove the legacy
BaseParamsimplementation and update tests to validate the new UIJson-based behavior. - Update the base UI JSON template and adjust dependency pinning/lock files for the updated
geoh5pyAPI.
Reviewed changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/uijson_run_test.py | Refactors tests to use a shared uijson_path fixture and new output naming. |
| tests/param_sweeps/generate_test.py | Updates test to serialize via options.ui_json. |
| tests/param_sweeps/driver_test.py | Updates test to serialize via options.ui_json. |
| tests/dataclass_test.py | Adjusts assertions and updates writing via params.ui_json.write(...). |
| tests/conftest.py | Introduces uijson_path fixture and updates test driver/options scaffolding. |
| tests/base_test.py | Aligns tests to UIJson serialization and new default-ui-json behavior. |
| pyproject.toml | Switches geoh5py dependency rev to feature/uijson. |
| geoapps_utils/run.py | Updates out-group execution and ui.json copying to use UIJson. |
| geoapps_utils/param_sweeps/generate.py | Reworks sweep-file generation around UIJson + base template. |
| geoapps_utils/param_sweeps/driver.py | Updates sweep driver to read/write UIJson and close workspace before copying. |
| geoapps_utils/driver/params.py | Removes legacy BaseParams implementation. |
| geoapps_utils/base.py | Updates Driver and Options to use UIJson as the primary representation. |
| geoapps_utils-assets/uijson/base.ui.json | Expands out_group into a full form object. |
| environments/py-3.14-win-64.conda.lock.yml | Refreshes locked dependency set for new geoh5py rev. |
| environments/py-3.14-win-64-dev.conda.lock.yml | Refreshes locked dependency set for new geoh5py rev. |
| environments/py-3.14-linux-64.conda.lock.yml | Refreshes locked dependency set for new geoh5py rev. |
| environments/py-3.14-linux-64-dev.conda.lock.yml | Refreshes locked dependency set for new geoh5py rev. |
| environments/py-3.13-win-64.conda.lock.yml | Refreshes locked dependency set for new geoh5py rev. |
| environments/py-3.13-win-64-dev.conda.lock.yml | Refreshes locked dependency set for new geoh5py rev. |
| environments/py-3.13-linux-64.conda.lock.yml | Refreshes locked dependency set for new geoh5py rev. |
| environments/py-3.13-linux-64-dev.conda.lock.yml | Refreshes locked dependency set for new geoh5py rev. |
| environments/py-3.12-win-64.conda.lock.yml | Refreshes locked dependency set for new geoh5py rev. |
| environments/py-3.12-win-64-dev.conda.lock.yml | Refreshes locked dependency set for new geoh5py rev. |
| environments/py-3.12-linux-64.conda.lock.yml | Refreshes locked dependency set for new geoh5py rev. |
| environments/py-3.12-linux-64-dev.conda.lock.yml | Refreshes locked dependency set for new geoh5py rev. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
# Conflicts: # environments/py-3.12-linux-64-dev.conda.lock.yml # environments/py-3.12-linux-64.conda.lock.yml # environments/py-3.12-win-64-dev.conda.lock.yml # environments/py-3.12-win-64.conda.lock.yml # environments/py-3.13-linux-64-dev.conda.lock.yml # environments/py-3.13-linux-64.conda.lock.yml # environments/py-3.13-win-64-dev.conda.lock.yml # environments/py-3.13-win-64.conda.lock.yml # environments/py-3.14-linux-64-dev.conda.lock.yml # environments/py-3.14-linux-64.conda.lock.yml # environments/py-3.14-win-64-dev.conda.lock.yml # environments/py-3.14-win-64.conda.lock.yml # geoapps_utils/driver/params.py # py-3.12.conda-lock.yml # py-3.13.conda-lock.yml # py-3.14.conda-lock.yml # pyproject.toml # tests/base_test.py # tests/dataclass_test.py
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #213 +/- ##
===========================================
- Coverage 85.95% 84.12% -1.83%
===========================================
Files 19 18 -1
Lines 1196 945 -251
Branches 155 123 -32
===========================================
- Hits 1028 795 -233
+ Misses 127 113 -14
+ Partials 41 37 -4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.