Skip to content

Add resource with pid to OTEL metrics#648

Merged
MarcelGeo merged 1 commit into
masterfrom
fix_metrics_missing_pid
Jul 1, 2026
Merged

Add resource with pid to OTEL metrics#648
MarcelGeo merged 1 commit into
masterfrom
fix_metrics_missing_pid

Conversation

@varmar05

@varmar05 varmar05 commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

This is to avoid multiple workers overwriting the same metrics in prometheus.

@varmar05 varmar05 requested a review from MarcelGeo July 1, 2026 07:29
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 28501099117

Coverage decreased (-0.03%) to 92.129%

Details

  • Coverage decreased (-0.03%) from the base build.
  • Patch coverage: 6 uncovered changes across 1 file (0 of 6 lines covered, 0.0%).
  • 1 coverage regression across 1 file.

Uncovered Changes

File Changed Covered %
server/mergin/otel/instrument.py 6 0 0.0%

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
server/mergin/otel/instrument.py 1 0.0%

Coverage Stats

Coverage Status
Relevant Lines: 10024
Covered Lines: 9235
Line Coverage: 92.13%
Coverage Strength: 0.92 hits per line

💛 - Coveralls

@MarcelGeo MarcelGeo merged commit aaedf9c into master Jul 1, 2026
5 checks passed
@MarcelGeo MarcelGeo deleted the fix_metrics_missing_pid branch July 1, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants