Fix white map sketching bugs#4578
Conversation
xkello
requested review from
Copilot and
tomasMizera
and removed request for
Copilot
📦 Build Artifacts Ready
|
tomasMizera
left a comment
tomasMizera
left a comment
There was a problem hiding this comment.
Fix formatting and it is ready to merge :)
| colors: root.sketchingController?.availableColors() ?? null | ||
| activeColor: root.sketchingController?.activeColor ?? null |
There was a problem hiding this comment.
btw using ?? here doesn't make sense
There was a problem hiding this comment.
Sketching controller can be undefined and often is at startup, but maybe that ?? null part could be skipped
There was a problem hiding this comment.
Seems to be working even without the ?? null parts. Removing it
There was a problem hiding this comment.
Yep I was just pointing to the ?? null part, if we don't give it some specific default value on null/undefined it doesn't really makes sense to use the operator to "double guarantee" the value will be null
Coverage Report for CI Build 28578186222Warning No base build found for commit Coverage: 59.026%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
📦 Build Artifacts Ready
|
3 participants
Description
This PR fixes several issues in map sketches related to color selection and eraser state:
613566402-ed4f7c50-72a8-41ff-853e-bb0283c29ce1.mp4
Changes
Final look
Screen_Recording_20260702-095514.mp4