repr/strconv: accept full u32 range when parsing oid from text#37440
Open
def- wants to merge 1 commit into
Open
repr/strconv: accept full u32 range when parsing oid from text#37440def- wants to merge 1 commit into
def- wants to merge 1 commit into
Conversation
`parse_oid` parsed OIDs as `i32` and reinterpreted them as `u32`, which rejected valid OIDs in `2147483648..=4294967295`. For example `'4294967295'::oid` errored even though `4294967295::oid` succeeded, and `COPY` into such a column failed with "invalid input syntax for type oid". PostgreSQL accepts the union of the `u32` and `i32` ranges (negatives are reinterpreted), so parse the full `u32` range directly and fall back to `i32` for negative inputs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_oidparsed OIDs asi32and reinterpreted them asu32, which rejected valid OIDs in2147483648..=4294967295. For example'4294967295'::oiderrored even though4294967295::oidsucceeded, andCOPYinto such a column failed with "invalid input syntax for type oid".PostgreSQL accepts the union of the
u32andi32ranges (negatives are reinterpreted), so parse the fullu32range directly and fall back toi32for negative inputs.Found via #34779