sql: reject SET TRANSACTION access modes at plan time#37436
Open
def- wants to merge 2 commits into
Open
Conversation
The sequencer applied each transaction mode's side effect in order before rejecting access modes, so `SET ... ISOLATION LEVEL x READ WRITE` changed the session isolation level and then errored, leaving it silently changed. Reject access modes in the planner (like `plan_start_transaction`) so no partial state is applied. Adds an SLT regression test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Rejecting SET TRANSACTION access modes via bail_unsupported! routed the error through the catch-all PlanError arm in AdapterError::code(), regressing the SQLSTATE from 0A000 (feature_not_supported) to XX000 (internal_error) and violating the SQL-326 invariant. Classify PlanError::Unsupported as FEATURE_NOT_SUPPORTED in both the AdapterError and OptimizerError paths, fixing every bail_unsupported! site. Update the stale sqllogictest message and add a pgtest that pins the 0A000 SQLSTATE so the classification cannot silently regress again. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sequencer applied each transaction mode's side effect in order before rejecting access modes, so
SET ... ISOLATION LEVEL x READ WRITEchanged the session isolation level and then errored, leaving it silently changed. Reject access modes in the planner (likeplan_start_transaction) so no partial state is applied. Adds an SLT regression test.