fix(#44): reconstruct() warns that QPD reconstruction is a placeholder - #95
Merged
Conversation
The reconstruct() method summed subcircuit counts uniformly and normalized, losing the sign and coefficient information required by proper quasi-probability decomposition. This produced incorrect expectation values when cuts were present. Fix: Add UserWarning when num_cuts > 0 explaining that results are not accurate and directing users to circuit_knitting from Qiskit Extensions. Add docstring warning. Add 3 regression tests. All 319 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix
The
reconstruct()method summed subcircuit counts uniformly and normalized, losing the sign and coefficient information required by proper quasi-probability decomposition. This produced incorrect expectation values when cuts were present.Changes:
All 319 tests pass.