feat(ci): add node-pnpm-ci reusable workflow#167
Open
kna-makerx wants to merge 2 commits into
Open
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ersion input is empty Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
🛡️ SHA Pinned Actions Report✅ All 29 file(s) passed — actions are allowed and pinned as required. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a reusable pnpm-based CI workflow and updates the existing pnpm build-zip workflow to support resolving pnpm from packageManager when the caller provides an empty pnpm version input.
Changes:
- Added reusable workflow
.github/workflows/node-pnpm-ci.ymlto run pnpm install/lint/typecheck/test (optionally build, commitlint, SBOM). - Updated
.github/workflows/node-pnpm-build-zip.ymlto conditionally set up pnpm either from an explicit version input or viapackageManagerinpackage.json.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/node-pnpm-ci.yml | New reusable pnpm CI workflow with optional commit linting, test reporting, build, and SBOM generation. |
| .github/workflows/node-pnpm-build-zip.yml | Adds conditional pnpm setup to allow packageManager-based pnpm resolution when pnpm-version is explicitly empty. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
9
to
+12
| required: false | ||
| type: string | ||
| default: "9" | ||
| description: Version of pnpm to use. Passing an explicit empty string defers resolution to the packageManager field of <working-directory>/package.json. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node-pnpm-ciGitHub Actions workflownode-pnpm-build-zipto resolve pnpm version frompackageManagerwhen the version input is emptyTest plan
node-pnpm-build-zipresolves the correct pnpm version whenpackageManageris set and no explicit version input is given