Fix/spelling typos 1498#1623
Open
engineer-scientist wants to merge 9 commits into
Open
Conversation
Author
|
@claude full review |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1623 +/- ##
=======================================
Coverage 60.39% 60.39%
=======================================
Files 83 83
Lines 19854 19854
Branches 2955 2955
=======================================
Hits 11990 11990
Misses 5863 5863
Partials 2001 2001 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Corrects the misspelled identifiers across the codebase. All are fixed here:
HardcodedDellacation→HardcodedDeallocation(src/common/include/ExtrusionHardcodedIC.fpp, src/pre_process/m_icpp_patches.fpp)tangental→tangential(src/simulation/m_collisions.fpp)fite_path_dest→file_path_dest(toolchain/mfc/test/case.py)lb→lB(src/common/m_finite_differences.fpp)The following is now obsolete because the upstream code now supersedes it:
BC_SlIP_WALL→BC_SLIP_WALL(src/common/m_boundary_common.fpp)Also fixes the following documentation typo that was blocking CI for everyone:
patche(s)→patch(es)(docs/documentation/case.md)Closes #1498.
Type of change
Testing
Verified zero remaining occurrences of all old spellings using:
grep -rn "HardcodedDellacation" src/grep -rn "tangental" src/grep -rn "fite_path_dest" src/No logic changes, purely identifier renames. No new tests added as this is a cosmetic fix with no behavioral change.
Checklist
GPU changes (expand if you modified
src/simulation/)