Orient.comp: Add modes with preceding homing to index - #4343
Open
Sigma1912 wants to merge 1 commit into
Open
Conversation
BsAtHome
reviewed
Aug 5, 2026
Sigma1912
force-pushed
the
Orient_Add-modes-with-index
branch
from
August 5, 2026 14:41
4f75431 to
56a499e
Compare
BsAtHome
reviewed
Aug 5, 2026
orient.comp currently does not support using an index signal. This makes it unusable for setups where the spindle encoder position cannot be tracked due to the encoder reading being too slow.
Sigma1912
force-pushed
the
Orient_Add-modes-with-index
branch
from
August 5, 2026 14:54
56a499e to
ddadd47
Compare
Contributor
Author
|
Thank you for reviewing and your pointers! Much appreciated. |
Contributor
|
You are welcome. I'm just looking at this on the structural level. Not looking at what it is actually doing ;-) There may be one more problem. You have a message printing when the mode value is not handled. If I'm not mistaking, this message would print at every thread-cycle flooding the terminal and GUI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some spindle encoder setups cannot track the encoder position when using high spindle speeds and thus cannot use the current 'orient' component due to lost encoder position.
This PR expands the orient component with three additional modes that offer referencing to an index signal prior to orienting the spindle.
Current behavior is unchanged. All modes have been tested on real hardware.
Based on work by @andypugh
For more:
https://forum.linuxcnc.org/10-advanced-configuration/42792-m19-and-spindle-index-enable-issues?start=10