Add support for GitHub-style alert - #158
Conversation
927b149 to
b208496
Compare
|
Love it. Hope this gets added! |
|
Sorry for the delay. Reviewing now! |
|
@guoPhineas Two issues:
|
|
|
||
| @Suite("Markdown Quote Alert") | ||
| struct MarkdownQuoteAlertTests { | ||
| @Test( |
| #expect(renderedBody.contains(fixture.expectedFirstBodyParagraph)) | ||
| } | ||
|
|
||
| @Test( |
|
@LiYanan2004 I just fixed the issues you raised. But the test isn't also passed. I speculate that there may be code logic issues with the current testing: The For this fixture, Swift Markdown produces the following AST:
However, when there is more than one child, the test uses: bodyChildren = Array(children.dropFirst())This discards the first paragraph, including The renderer should strip the alert marker/title line from the first paragraph, preserve the remaining inline content, and then append the remaining blockquote children. The implementation now follows that behavior, but the test’s extraction logic would need the same adjustment. So, I fixed the issue in |

WIP