Skip to content

fix(jni): free QueryResult on Arrow entry-point failure #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adsharma merged 1 commit into from
Aug 1, 2026
+16 −0
Merged

fix(jni): free QueryResult on Arrow entry-point failure #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/jni/lbug_java.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -832,6 +832,10 @@ JNIEXPORT jobject JNICALL Java_com_ladybugdb_Native_lbugConnectionCreateArrowTab
auto state = lbug_connection_create_arrow_table(conn, table.c_str(), schema, arrays,
static_cast<uint64_t>(numArrays), queryResult);
if (state != LbugSuccess) {
// The C API can release a QueryResult into the out-param before
// reporting failure (see Connection::setQueryResult). The wrapper
// does not own it, so `delete` alone would leak.
lbug_query_result_destroy(queryResult);
delete queryResult;
throwLastError(env, "Failed to create Arrow table");
return jobject();
Expand Down Expand Up @@ -859,6 +863,10 @@ JNIEXPORT jobject JNICALL Java_com_ladybugdb_Native_lbugConnectionCreateArrowRel
auto state = lbug_connection_create_arrow_rel_table(conn, table.c_str(), srcTable.c_str(),
dstTable.c_str(), schema, arrays, static_cast<uint64_t>(numArrays), queryResult);
if (state != LbugSuccess) {
// The C API can release a QueryResult into the out-param before
// reporting failure (see Connection::setQueryResult). The wrapper
// does not own it, so `delete` alone would leak.
lbug_query_result_destroy(queryResult);
delete queryResult;
throwLastError(env, "Failed to create Arrow relationship table");
return jobject();
Expand Down Expand Up @@ -898,6 +906,10 @@ JNIEXPORT jobject JNICALL Java_com_ladybugdb_Native_lbugConnectionCreateArrowRel
static_cast<uint64_t>(numIndicesArrays), indptrSchema, indptrArrays,
static_cast<uint64_t>(numIndptrArrays), dstColumnPtr, queryResult);
if (state != LbugSuccess) {
// The C API can release a QueryResult into the out-param before
// reporting failure (see Connection::setQueryResult). The wrapper
// does not own it, so `delete` alone would leak.
lbug_query_result_destroy(queryResult);
delete queryResult;
throwLastError(env, "Failed to create Arrow CSR relationship table");
return jobject();
Expand All @@ -919,6 +931,10 @@ JNIEXPORT jobject JNICALL Java_com_ladybugdb_Native_lbugConnectionDropArrowTable
auto* queryResult = new lbug_query_result();
auto state = lbug_connection_drop_arrow_table(conn, table.c_str(), queryResult);
if (state != LbugSuccess) {
// The C API can release a QueryResult into the out-param before
// reporting failure (see Connection::setQueryResult). The wrapper
// does not own it, so `delete` alone would leak.
lbug_query_result_destroy(queryResult);
delete queryResult;
throwLastError(env, "Failed to drop Arrow table");
return jobject();
Expand Down
Loading