SQL Server Migration 1#955
Open
labkey-bpatel wants to merge 9 commits into
Open
Conversation
… and fix upgrade script. Fix query errors during Folder import.
…fb_sql_server_migration_1
…fb_sql_server_migration_1
…fb_sql_server_migration_1
Open
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
As part of migrating from SQL Server to Postgres, this PR updates queries and shared LabKey SQL method support for the SQL Server to PostgreSQL migration. The changes replace SQL Server-specific syntax, add explicit casts where PostgreSQL requires stricter type resolution.
Related Pull Requests
Changes
snprc_ehrandsnprc_geneticsnow declare bothmssqlandpgsqlas supported databases+operator with the standard||across all SNPRC custom queries so display values, labels, and concatenated identifiers render correctly on both dialects.charindex/lenfor the portableLOCATE/LENGTHin the SND lookup export queries and the demographics/audit-history queries.lp.ServiceIdvsobr.PROCEDURE_IDtypes across the HL7 pivot queries so the inner joins resolve on Postgres.= 0) with boolean literals (= false), and replacedtruncatewithFLOORin age-range formattingBaboonColonyGroupsnow use a literal list; the dynamic form fails LabKey query validation against an empty lookup table. Documented in-line as a maintenance trade-off — adding a new colony group now requires touching these queries.