App Deployments (2/N): admin catalog + cluster management API#215
Merged
Conversation
Increment 2 of the App Deployments epic. Admin-only CRUD for the managed
app catalog and the clusters apps deploy to.
- AdminResource::App = 26 (Display/FromStr/TryFrom/all) + RBAC migration
granting app::* to super_admin.
- Endpoints:
- GET/POST /api/admin/v1/apps, GET/PATCH/DELETE /api/admin/v1/apps/{id}
- GET/POST /api/admin/v1/app_clusters, GET/PATCH/DELETE .../{id}
- Apps carry a docker-compose-style compose YAML + inline subscription
pricing; clusters bind to a region (billing company) + ingress domain.
- Validation: DNS-safe slug, required display_name/compose/currency,
currency upper-cased, region existence checked on cluster create/update;
delete refused while deployments exist. Full compose schema validation is
deferred to the operator.
- Unit test for validate_app_fields; e2e admin CRUD test (apps + clusters,
duplicate/invalid rejection, auth enforcement).
- ADMIN_API_ENDPOINTS.md + API_CHANGELOG.md.
Part of work/app-deployments.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second increment of the managed App Deployments epic (see
work/app-deployments.md). Builds on the DB foundation (#214). Admin-only surface; no customer endpoints yet.What
appadmin permission (AdminResource::App = 26) + RBAC migration grantingapp::*tosuper_admin.GET/POST /api/admin/v1/apps,GET/PATCH/DELETE /api/admin/v1/apps/{id}. Each app carries a docker-compose-stylecomposeYAML plus inline subscription pricing.GET/POST /api/admin/v1/app_clusters,GET/PATCH/DELETE /api/admin/v1/app_clusters/{id}. Each cluster binds to aregion(which provides the billing company) and an ingress domain.Validation
display_name/compose/currency; currency upper-cased.composeschema validation is intentionally deferred to the operator (increment 4), which owns the compose→k8s mapping.Tests / docs
validate_app_fields(all branches).Next