Skip to content

Filter zero-variance groups after infra checks#71

Draft
nightlessbaron wants to merge 2 commits into
prodfrom
agent/filter-zero-variance-groups
Draft

Filter zero-variance groups after infra checks#71
nightlessbaron wants to merge 2 commits into
prodfrom
agent/filter-zero-variance-groups

Conversation

@nightlessbaron

Copy link
Copy Markdown

Summary

  • reject all-correct and all-incorrect rollout groups after infra/abort validation
  • preserve the existing abort and infra-failure rejection precedence
  • cover every configured infra status plus nested, mixed, and zero-variance groups

Dependency

This is stacked on #60 and therefore temporarily includes #60's commits in the prod diff. Rebase onto prod after #60 lands.

Validation

  • pytest -q --confcutdir=tests/fast/rollout tests/fast/rollout/test_dynamic_sampling_filters.py (20 passed)
  • Black and Ruff on both changed files
  • py_compile
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant