fix: correct openapi2mcp mode values to match the ai-mcp-proxy plugin - #301
Merged
Conversation
The plugin never supported a "conversion" mode - that value was invalid and produced misleading CLI help output. The real modes are passthrough-listener, conversion-listener, conversion-only, and listener. "conversion" is kept working as a deprecated alias for conversion-only so existing callers don't break. Also corrects which modes get ACL fields (acl_attribute_type, access_token_claim_field): every listener mode gets them, not just conversion-listener as before. Fixes Kong/deck#2181
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #301 +/- ##
==========================================
- Coverage 65.70% 58.82% -6.88%
==========================================
Files 25 36 +11
Lines 3260 3869 +609
==========================================
+ Hits 2142 2276 +134
- Misses 905 1380 +475
Partials 213 213 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
harshadixit12
approved these changes
Aug 11, 2026
Contributor
|
LGTM - Thank you for the detailed description, and keeping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deck file openapi2mcp --modeaccepted and advertised a mode called "conversion" that the ai-mcp-proxy plugin has never actually supported. The plugin's real modes arepassthrough-listener,conversion-listener,conversion-only, andlistener-conversionisn't one of them.Full changelog
openapi2mcpnow accepts and validates the plugin's real modes:passthrough-listener,conversion-listener,conversion-only,listener.conversionis kept working as a deprecated alias forconversion-only, so existing usage doesn't break.acl_attribute_type,access_token_claim_field) are now generated for every listener mode, not justconversion-listener.Issues resolved
Fixes [Kong/deck#2181] Issue : Kong/deck#2181
Testing