Refactor build management UI and logic - #3925
Open
jjomier wants to merge 3 commits into
Open
Conversation
jjomier
force-pushed
the
jjomier/groups_ux
branch
from
August 6, 2026 21:13
cf2e938 to
5994ea3
Compare
Collaborator
|
@jjomier It looks like CI failed to run due to yesterday's GitHub Actions outage. Please amend your latest commit and force push to re-trigger CI. |
- Updated the build admin options panel to improve clarity and usability, including renaming properties for better understanding. - Introduced a dropdown for moving builds between groups, ensuring the current group is excluded from the selection. - Enhanced the moveToGroup function to preserve the expected status of builds during group transitions. - Updated Cypress tests to validate the new dropdown functionality and expected status behavior.
jjomier
force-pushed
the
jjomier/groups_ux
branch
from
August 7, 2026 12:09
5994ea3 to
d218f6d
Compare
- Updated arrow function syntax in Cypress tests for consistency and clarity. - Enhanced the readability of test code by ensuring uniform use of parentheses in function definitions. - No changes to test logic or functionality; focus was on code style improvements.
williamjallen
requested changes
Aug 7, 2026
williamjallen
left a comment
williamjallen
left a comment
Collaborator
There was a problem hiding this comment.
@jjomier Thanks for this contribution. This is something I've been wanting to see cleaned up for a while.
I like how the new design makes it clear that you can only move a build to a single build group. I think there's still room for improvement though. A few thoughts/questions:
- Is there a more intuitive way to structure the "This build is not expected to submit" text and associated button? Right now, it's not immediately clear that the text is associated with the button, or that the button will toggle the state indicated by the text.
- I think the dark line should be removed.
- It feels like the "Remove This Build" and "Mark As Done" buttons are placed arbitrarily. Perhaps putting these two buttons in line with the "Mark As Expected" button discussed above would make it cleaner?
- Instead of "Select Group", should the build group dropdown instead default to the current build group (with the "Move" button still disabled)? Doing so would probably allow for the "Move this build to" text to be removed.
- Added CSS to suppress focus ring on mouse clicks for better accessibility during keyboard navigation. - Updated the build admin options panel to improve layout and usability, including clearer button labels for marking builds as expected or not expected. - Adjusted the move-to-group dropdown to default to the current group and ensure it is disabled when selecting the same group. - Refined Cypress tests to validate the new UI behavior and ensure expected status functionality is correctly implemented.
Contributor
Author
|
@williamjallen I just updated the UI (see screenshot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.