Ci: fix issue-to-PR inside the container - #173
Merged
Merged
Conversation
First dispatch of the repaired workflow failed on both open submissions: `node: command not found`. JS actions run on the runner's own node mounted into the container, but a `run:` step only sees what the image ships, and fedora:43 ships none — the render step sat ahead of actions/setup-node. Move setup-node in front of it; it still runs before the dependency install, so a bad submission fails in seconds. Two more container defects found with it: - `runner.temp` yields the HOST path in a container job while $RUNNER_TEMP yields the mounted one, so EXAMPLE_ERROR_FILE pointed nowhere. Use the env var on both the writing and the reading side. - The failure comment blamed the submission for any failure. When the renderer wrote no reason the fault is the automation's, and telling contributors to fix their example sends them after a bug that is not theirs — which is exactly what the failed dispatch did. Say which of the two it was. Also claim the work tree once after checkout instead of before `git commit` only, and emit displayMemory pre-wrapped so the rendered meta.ts is already canonical and `gjsify format` has nothing to rewrite. Claude-Session: https://claude.ai/code/session_01FrdNDUY1rJWBJsDU1KAwKj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #172. The first dispatch of the repaired workflow failed on both open submissions with
node: command not found.JS actions (
actions/github-script) run on the runner's own node mounted into the container, but arun:step only sees what the image ships — andfedora:43ships none. The render step sat ahead ofactions/setup-node. Moved setup-node in front of it; it still runs before the dependency install, so an unusable submission fails in seconds rather than after a full install.Two more container defects found alongside it:
runner.tempis the host path. In a container job the expression yields/home/runner/work/_tempwhile$RUNNER_TEMPyields the mounted/__w/_temp.EXAMPLE_ERROR_FILEtherefore pointed at a directory that does not exist inside the container, so the rejection reason could never be read back. Use the env var on both the writing and the reading side.Also: claim the work tree with
safe.directoryonce after checkout rather than only in front ofgit commit, and emitdisplayMemorypre-wrapped so the renderedmeta.tsis already canonical andgjsify formathas nothing to rewrite — verified withgjsify format --checkagainst both open submissions.https://claude.ai/code/session_01FrdNDUY1rJWBJsDU1KAwKj