Add auto approve scope requests & add corresponding settings in manager - #909
Closed
Electric1447 wants to merge 1 commit into
Closed
Add auto approve scope requests & add corresponding settings in manager#909Electric1447 wants to merge 1 commit into
Electric1447 wants to merge 1 commit into
Conversation
Contributor
Author
|
It seems the CI failed due to missing translations. |
Owner
|
I think users must explicitly accord the scope, won't merge. |
Contributor
Author
|
maybe there is a way to make the notification pop like the magisk superuser request popup? |
Owner
|
@Electric1447 That sounds like a nice improvement. If you find the direction, I will be happy to help you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was working on a module that used Vector to inject .so files to apps.
I also managed the scopes from the module and I updated Vector to allow to auto accept scope request from the manager.