fix(deps): declare undeclared mcp dependency - #3
Draft
JRM-FusionAL wants to merge 1 commit into
Draft
Conversation
server.py does `from mcp.server.fastmcp import FastMCP`, but `mcp` (the official MCP Python SDK) was never declared in pyproject.toml — it only worked because fastmcp pulls it in transitively with a `<2.0` ceiling. mcp shipped a breaking v2.0.0 (2026-07-28) that removes `mcp.server.fastmcp` entirely with no compatibility shim; if anything ever resolves mcp>=2.0 in this environment, the import hard-fails. Declaring the constraint explicitly also makes clear why the code is protected from CVE-2025-66416 (DNS-rebinding, fixed <1.23.0) instead of that being incidental. Found via scheduled dependency audit (2026-08-12).
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix found by a scheduled dependency audit (2026-08-12) covering all JRM-FusionAL repos.
server.pydoesfrom mcp.server.fastmcp import FastMCP, butmcp(the official MCP Python SDK) was never declared inpyproject.toml— onlyfastmcp>=3.2.0is, and it happens to pullmcp<2.0in transitively today.mcpshipped a breakingv2.0.0two weeks before this audit (2026-07-28) that removesmcp.server.fastmcpentirely with no compatibility shim. If anything in the dependency graph ever resolvesmcp>=2.0(a futurefastmcprelease that lifts its<2.0ceiling, a different transitive path, a manualpip install -U mcp), this import hard-fails.Added an explicit
mcp>=1.23.0,<2.0dependency so the constraint — and the reason for it — is visible inpyproject.tomlinstead of being an accident offastmcp's own pin.1.23.0is also the CVE-2025-66416 (DNS-rebinding) fix version, so the floor documents that protection explicitly too.Test plan
pip install -e .resolves cleanly andmcpshows up as a direct (not just transitive) dependencygithub-mcp-safestill starts and serves as expected🤖 Generated with Claude Code
Generated by Claude Code