Skip to content

Task: Remove Ui UX in ./wasm/#1714

Merged
xsscx merged 4 commits into
masterfrom
ci-wasm-remove-ui-ux
Jul 18, 2026
Merged

Task: Remove Ui UX in ./wasm/#1714
xsscx merged 4 commits into
masterfrom
ci-wasm-remove-ui-ux

Conversation

@xsscx

@xsscx xsscx commented Jul 18, 2026

Copy link
Copy Markdown
Member

PR Summary

Checklist

  • Signed all Commits in PR
  • Built locally according to docs/build.md
  • Followed the guidelines in Contributing document
  • Ran relevant CTest/profile tests from docs/ctest.md
  • Updated documentation for user-visible behavior changes
  • Ran sanitizer coverage for memory-safety or parser changes
  • Added or updated regression coverage for behavior changes
  • For Python package changes, followed docs/python-packaging-release.md for PR and merge requirements
  • Did not change maintainer-owned workflow, CTest, CPack, sanitizer, release, or security infrastructure unless requested by an iccDEV maintainer
  • New source files include the ICC copyright and BSD 3-Clause license header
  • Code style matches nearby code: 2-space indent, K&R braces, m_ members

Legal Requirements

All official software projects hosted by the International Color Consoritum (ICC)
follows the open source software best practice policies. The International Color Consoritum IP policy governs ICC specification development and contributions to ICC open source software. Software contributions are also covered by the Contributor License Agreement (CLA).

Contributor License Agreements

Developers who wish to contribute code to be considered for inclusion
in ICC software must first complete a Contributor License Agreement
(CLA)
.

There is no cost or membership requirement to sign the ICC Contributor License Agreement (CLA). Please note that this is different from membership in the International Color Consortium (ICC). If your organization relies on our projects, please become a member. Membership dues are an essential source of funding and investment for these projects.

  • If you are an individual writing the code on your own time and you are SURE you are the sole owner of any intellectual property you contribute, you can sign the CLA as an individual contributor.

  • If you are writing the code as part of your job, or if there is any possibility that your employer might think they own any intellectual property you create, then you should use the Corporate Contributor Licence Agreement

License

ICC software is licensed under the BSD 3-Clause "New" or "Revised" License. Contributions to ICC software projects should abide by that license unless otherwised specified or approved by the ICC.

Copyright Notices

All new source files must begin with the ICC Copyright notice and include or reference the BSD 3-Clause "New" or "Revised" License.

INTELLECTUAL PROPERTY & PATENTS

Participation in ICC's development activities is subject to ICC's Patent Policy.

Maintainer Review Required

If you have questions, contact a listed Maintainer.

@xsscx xsscx added this to the v2.3.2.3 milestone Jul 18, 2026
Copilot AI review requested due to automatic review settings July 18, 2026 01:29
@xsscx
xsscx requested a review from ChrisCoxArt as a code owner July 18, 2026 01:29
@xsscx
xsscx enabled auto-merge (squash) July 18, 2026 01:29
@xsscx
xsscx removed the request for review from ChrisCoxArt July 18, 2026 01:29
@github-actions github-actions Bot added the pending CI checks still running label Jul 18, 2026
@xsscx xsscx linked an issue Jul 18, 2026 that may be closed by this pull request
@xsscx xsscx self-assigned this Jul 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the browser UI layer from wasm/, leaving WASM build/package infrastructure elsewhere in the repository.

Changes:

  • Deletes 17 browser pages.
  • Removes shared UI runtime, sanitization, and styling assets.
  • Removes browser-suite documentation.

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.

Show a summary per file
File Description
wasm/app.js Removes shared browser runtime.
wasm/apply.html Removes profile-application UI.
wasm/dump.html Removes profile-dump UI.
wasm/fromcube.html Removes CUBE conversion UI.
wasm/fromjson.html Removes JSON import UI.
wasm/fromxml.html Removes XML import UI.
wasm/index.html Removes browser tool index.
wasm/jpegdump.html Removes JPEG inspection UI.
wasm/link.html Removes device-link UI.
wasm/namedcmm.html Removes named-CMM UI.
wasm/pngdump.html Removes PNG inspection UI.
wasm/README.md Removes browser-suite documentation.
wasm/roundtrip.html Removes round-trip UI.
wasm/sanitize.js Removes client-side sanitization helpers.
wasm/search.html Removes transform-search UI.
wasm/specsep.html Removes spectral-separation UI.
wasm/style.css Removes shared UI styling.
wasm/tiffdump.html Removes TIFF inspection UI.
wasm/tojson.html Removes JSON export UI.
wasm/toxml.html Removes XML export UI.
wasm/v5dsp.html Removes v5-to-v4 conversion UI.
Comments suppressed due to low confidence (2)

wasm/index.html:1

  • Removing the page without updating iccdev-mcp/tests/test_wasm_html.py leaves the repository's WASM HTML suite guaranteed to fail whenever Playwright is installed: test_all_pages_present() still requires all 17 deleted pages, and additional tests directly read index.html, app.js, style.css, and sanitize.js. Remove or replace that obsolete test module as part of this cleanup.
    wasm/README.md:1
  • Deleting this browser-suite documentation leaves the canonical .github/skills/wasm-build-test/SKILL.md instructions stale: they still tell maintainers to copy wasm/*.html, wasm/*.css, and wasm/*.js, run the deleted HTML suite, and open these pages. Update that skill and its routed WASM guidance so the documented build/test workflow matches the new module-only scope.

@xsscx xsscx added the Copilot Copilot use indicated by Maintainer label Jul 18, 2026
@xsscx
xsscx disabled auto-merge July 18, 2026 01:35
Copilot AI review requested due to automatic review settings July 18, 2026 01:38
@github-actions github-actions Bot added Documentation Documentation-only or documentation-related change Build Build system, CMake, compiler, or packaging Governance Maintainer-owned policy, CODEOWNERS, prompts, or skills labels Jul 18, 2026
@xsscx

xsscx commented Jul 18, 2026

Copy link
Copy Markdown
Member Author

PR Author Comment

2026-07-18 01:38:29 UTC

The Copilot low-confidence items seen above are correct, and are being addressed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated 5 comments.

Comment thread .github/skills/wasm-build-test/SKILL.md Outdated
Comment thread .github/skills/wasm-build-test/SKILL.md
Comment thread .github/skills/wasm-build-test/SKILL.md Outdated
Comment thread .github/prompts/debug-wasm-build.prompt.md Outdated
Comment thread Build/Cmake/wasm-package/README.md Outdated
Copilot AI review requested due to automatic review settings July 18, 2026 01:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.

Comment thread .github/prompts/debug-wasm-build.prompt.md
Copilot AI review requested due to automatic review settings July 18, 2026 01:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated no new comments.

@xsscx
xsscx merged commit 7493bb0 into master Jul 18, 2026
40 checks passed
@xsscx
xsscx deleted the ci-wasm-remove-ui-ux branch July 18, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build Build system, CMake, compiler, or packaging Copilot Copilot use indicated by Maintainer Documentation Documentation-only or documentation-related change Governance Maintainer-owned policy, CODEOWNERS, prompts, or skills pending CI checks still running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Task: Remove Ui UX in ./wasm/

2 participants