Task: Remove Ui UX in ./wasm/#1714
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the browser UI layer from wasm/, leaving WASM build/package infrastructure elsewhere in the repository.
Changes:
- Deletes 17 browser pages.
- Removes shared UI runtime, sanitization, and styling assets.
- Removes browser-suite documentation.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
wasm/app.js |
Removes shared browser runtime. |
wasm/apply.html |
Removes profile-application UI. |
wasm/dump.html |
Removes profile-dump UI. |
wasm/fromcube.html |
Removes CUBE conversion UI. |
wasm/fromjson.html |
Removes JSON import UI. |
wasm/fromxml.html |
Removes XML import UI. |
wasm/index.html |
Removes browser tool index. |
wasm/jpegdump.html |
Removes JPEG inspection UI. |
wasm/link.html |
Removes device-link UI. |
wasm/namedcmm.html |
Removes named-CMM UI. |
wasm/pngdump.html |
Removes PNG inspection UI. |
wasm/README.md |
Removes browser-suite documentation. |
wasm/roundtrip.html |
Removes round-trip UI. |
wasm/sanitize.js |
Removes client-side sanitization helpers. |
wasm/search.html |
Removes transform-search UI. |
wasm/specsep.html |
Removes spectral-separation UI. |
wasm/style.css |
Removes shared UI styling. |
wasm/tiffdump.html |
Removes TIFF inspection UI. |
wasm/tojson.html |
Removes JSON export UI. |
wasm/toxml.html |
Removes XML export UI. |
wasm/v5dsp.html |
Removes v5-to-v4 conversion UI. |
Comments suppressed due to low confidence (2)
wasm/index.html:1
- Removing the page without updating
iccdev-mcp/tests/test_wasm_html.pyleaves the repository's WASM HTML suite guaranteed to fail whenever Playwright is installed:test_all_pages_present()still requires all 17 deleted pages, and additional tests directly readindex.html,app.js,style.css, andsanitize.js. Remove or replace that obsolete test module as part of this cleanup.
wasm/README.md:1 - Deleting this browser-suite documentation leaves the canonical
.github/skills/wasm-build-test/SKILL.mdinstructions stale: they still tell maintainers to copywasm/*.html,wasm/*.css, andwasm/*.js, run the deleted HTML suite, and open these pages. Update that skill and its routed WASM guidance so the documented build/test workflow matches the new module-only scope.
xsscx
disabled auto-merge
July 18, 2026 01:35
Member
Author
PR Author Comment2026-07-18 01:38:29 UTC The Copilot low-confidence items seen above are correct, and are being addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Checklist
docs/build.mddocs/ctest.mddocs/python-packaging-release.mdfor PR and merge requirementsm_membersLegal Requirements
All official software projects hosted by the International Color Consoritum (ICC)
follows the open source software best practice policies. The International Color Consoritum IP policy governs ICC specification development and contributions to ICC open source software. Software contributions are also covered by the Contributor License Agreement (CLA).
Contributor License Agreements
Developers who wish to contribute code to be considered for inclusion
in ICC software must first complete a Contributor License Agreement
(CLA).
There is no cost or membership requirement to sign the ICC Contributor License Agreement (CLA). Please note that this is different from membership in the International Color Consortium (ICC). If your organization relies on our projects, please become a member. Membership dues are an essential source of funding and investment for these projects.
If you are an individual writing the code on your own time and you are SURE you are the sole owner of any intellectual property you contribute, you can sign the CLA as an individual contributor.
If you are writing the code as part of your job, or if there is any possibility that your employer might think they own any intellectual property you create, then you should use the Corporate Contributor Licence Agreement
License
ICC software is licensed under the BSD 3-Clause "New" or "Revised" License. Contributions to ICC software projects should abide by that license unless otherwised specified or approved by the ICC.
Copyright Notices
All new source files must begin with the ICC Copyright notice and include or reference the BSD 3-Clause "New" or "Revised" License.
INTELLECTUAL PROPERTY & PATENTS
Participation in ICC's development activities is subject to ICC's Patent Policy.
Maintainer Review Required
If you have questions, contact a listed Maintainer.