Remvoe extra files when restoring snapshots#25
Open
kerthcet wants to merge 2 commits into
Open
Conversation
Signed-off-by: kerthcet <kerthcet@gmail.com>
InftyAI-Agent
added
needs-triage
Member
Author
|
/kind bug |
InftyAI-Agent
added
bug
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the snapshot restore path in SnapshotManager to make restores “clean” by removing files/directories in the destination that are not present in the snapshot, and adds a regression test to validate that behavior.
Changes:
- Add a post-restore cleanup phase that deletes “extra” entries in the restore destination directory.
- Document the new restore semantics in
restore_tree. - Add a test ensuring extras are removed after a restore.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: kerthcet <kerthcet@gmail.com>
kerthcet
force-pushed
the
fix/remove-extra-files
branch
from
ef3e6ea to
f938dfb
Compare
Member
Author
|
/lgtm |
InftyAI-Agent
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?