Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@
"LICENSE"
],
"dependencies": {
"@cacheable/net": "^2.0.8",
"cacheable": "^2.3.5",
"@cacheable/net": "^2.1.0",
"cacheable": "^2.5.0",
"hookified": "^3.0.0",
"pino": "^10.3.1"
}
Expand Down
41 changes: 21 additions & 20 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 13 additions & 1 deletion test/net-info.test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import process from "node:process";
import { describe, expect, test } from "vitest";
import { describe, expect, test, vi } from "vitest";
import { ErrorMessages } from "../src/base-service.js";
import { NetInfo } from "../src/net-info.js";

Expand Down Expand Up @@ -155,4 +155,16 @@ describe("NetInfo", () => {
expect(ipInfos).toBeDefined();
expect(ipInfos.length).toBe(0);
});

test("should return an error result when the request throws", async () => {
const netInfo = new NetInfo({ apiKey: "test_api_key" });
netInfo.on("error", () => {});
// With @cacheable/net returning non-2xx responses instead of throwing,
// force a thrown error to exercise the catch path.
netInfo.get = vi.fn().mockRejectedValue(new Error("network down"));
const ipInfo = await netInfo.getIpInfo("1.1.1.1");
expect(ipInfo).toHaveProperty("ip", "1.1.1.1");
expect(ipInfo).toHaveProperty("type", "error");
expect(ipInfo).toHaveProperty("errorMessage", "network down");
});
});
19 changes: 18 additions & 1 deletion test/toggle.test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Cacheable } from "cacheable";
import { describe, expect, test } from "vitest";
import { describe, expect, test, vi } from "vitest";
import { Toggle, type ToggleOptions } from "../src/toggle.js";
import { getRandomToggleContext, mockToggleContexts } from "./mock-contexts.js";

Expand Down Expand Up @@ -663,4 +663,21 @@ describe("Hyphen sdk", () => {
expect(result).toBe(false); // Returns defaultValue when error occurs
});
});

describe("fetch", () => {
test("should extract the status code from CacheableNet error messages", async () => {
const toggle = new Toggle({ horizonUrls: ["https://horizon.example"] });
// @cacheable/net surfaces HTTP failures as errors whose message
// includes "status <code>"; verify that code is parsed out.
toggle._net.fetch = vi
.fn()
.mockRejectedValue(new Error("Request failed with status 404"));

await expect(
toggle.fetch("/toggle/evaluate", { key: "value" }),
).rejects.toThrow(
"All horizon URLs failed. Last errors: HTTP 404: Request failed with status 404",
);
});
});
});