fix(cli): stop reprocess dumping full result JSON on success#444
Merged
Conversation
`reprocess` emitted the entire pipeline result (model_dump, incl. ~4KB of captured graph_stderr / vectors subprocess logs) on success — noise that was already surfaced via the progress renderer. `init`/`increment` already emit a one-line success payload; reprocess now matches. - `_emit_reprocess_outcome`: emit a concise success payload (reuses the pipeline `message` when set, e.g. the graph-only-install note); keep the full payload only for failures, where captured stdout/stderr aid debugging. Partial-mode TTY "Rebuilt/Skipped" summary preserved. - Update 3 stale test assertions + the reprocess stdout baseline fixture to the new contract. - Also fix a pre-existing stale `increment` assertion in the heavy lifecycle test (default increment now does Lance + graph, not Lance-only). Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
java-codebase-rag reprocessprinted the entire pipeline result as a giant JSON blob to stdout on success:Those
graph_stderr/stderr/stdoutfields hold captured subprocess logs that were already rendered as progress bars (and relayed to stderr) — re-emitting them as a single-line JSON payload was pure noise. This was inconsistent withinit/increment, which emit a one-line{"message": "...", "success": true}on success.Root cause: the default full-reprocess path did
payload = result.model_dump()→_emit(payload)unconditionally on success.Fix
_emit_reprocess_outcomenow:{"success": true, "message": "reprocess completed"}(matchesinit/increment). Partial modes get"(vectors only; ...)"/"(graph only; ...)"; the graph-only-install note fromrun_refresh_pipelineis preserved. TTY partial modes still print the "Rebuilt:/Skipped:" summary.Result:
Test changes
reprocessstdout baseline fixture + 3 stale assertions to the new contract (partial-mode success no longer carriesphases_run; failure/preflight paths still emit the full payload).incrementalready does Lance + graph ("increment completed (Lance + graph updated)"), but the test still expected the old Lance-only message — this was blocking the heavy test from validating the reprocess change.Validation
init/increment/reprocesssuccess payloads verified end-to-end).🤖 Generated with Claude Code