fix: use per-sample dice computation in DiceLoss to match CrossEntropyLoss mean reduction (#74)#101
Open
rtmalikian wants to merge 1 commit into
Open
Conversation
…yLoss mean reduction (HiLab-git#74) The DiceLoss._dice_loss() computed the dice coefficient using torch.sum across all batch elements simultaneously. While the dice coefficient is a ratio (bounded 0-1), computing it over the entire batch instead of per-sample means that samples with different characteristics (common in medical imaging) can mask each other's contribution to the loss. This changes _dice_loss() to compute the dice coefficient per-sample and return the batch average, consistent with CrossEntropyLoss's default 'mean' reduction behavior. When batch samples have different anatomy or pathology, the old approach could produce loss values that don't reflect individual sample quality. For example, a well-predicted sample can dilute the loss from a poorly-predicted sample in the same batch. Per-sample computation ensures each sample contributes equally to the training signal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #74
Problem
DiceLoss._dice_loss()computes the dice coefficient usingtorch.sumacross all batch elements simultaneously, rather than per-sample. While the dice coefficient is a ratio (bounded 0-1), computing it over the entire batch means that samples with different characteristics — common in medical imaging where anatomy and pathology vary across subjects — can mask each other's contribution to the loss.When combined with
CrossEntropyLoss()(which defaults toreduction='mean'), as done in all training scripts:the dice loss behavior doesn't align with the expected per-sample mean reduction.
Solution
Changed
DiceLoss._dice_loss()to compute the dice coefficient per-sample and return the batch average. This ensures:CrossEntropyLoss's default mean reductionVerification
Tested with:
About the Author: Raphael Malikian — Clinical AI Solutions Architect. I specialise in building and fixing AI/ML systems for healthcare, including vector databases, RAG pipelines, and clinical NLP. If you need help with your project or think I can add value to your organisation, feel free to reach out — I'd love to connect.
📧 rtmalikian@gmail.com
🔗 GitHub: https://github.com/rtmalikian
🔗 LinkedIn: http://www.linkedin.com/in/raphael-t-malikian-mbbs-bsc-hons-71075436a
Disclosure: This code was developed with assistance from mimo-2.5-pro (Xiaomi) via Hermes Agent (Nous Research). All changes were reviewed, tested against the actual codebase, and verified for correctness.