Expose SMTP TLS controls for local relays#1244
Open
realicon23 wants to merge 1 commit into
Open
Conversation
Self-hosted Docker installs can relay through an internal SMTP server that advertises STARTTLS with a private or self-signed certificate. Symfony Mailer enables opportunistic STARTTLS by default, so MAIL_ENCRYPTION=null is not enough to avoid certificate verification failures. Expose MAIL_AUTO_TLS and MAIL_VERIFY_PEER through the Hi.Events SMTP mailer config. These map to Symfony's SMTP DSN options, preserve secure defaults, and let trusted internal relays opt out explicitly when needed. Pass the variables through the all-in-one Docker compose file, document the defaults in env examples, and add a focused test that verifies the options reach Symfony's EsmtpTransport and socket stream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1186.
Why
Self-hosted Docker deployments can relay mail through an internal SMTP server that advertises STARTTLS with a private or self-signed certificate. Symfony Mailer enables opportunistic STARTTLS by default, so leaving
MAIL_ENCRYPTIONempty does not necessarily stop the transport from upgrading to STARTTLS.Laravel passes the SMTP mailer config through to Symfony's SMTP DSN options, and Symfony already supports
auto_tlsandverify_peer. This keeps the secure defaults in place while giving trusted internal relays an explicit opt-out.What changed
MAIL_AUTO_TLSandMAIL_VERIFY_PEERto the SMTP mailer config.EsmtpTransportand socket stream.Verification
Focused result:
1 test, 4 assertions.I also ran the full backend unit suite. It completed with the existing
NoInternalUrlRuleTestexternal URL failures, which are unrelated to this mail config change.