Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new button-like styling is applied to HyperlinkButton, which keeps “link” semantics and can create an accessibility mismatch between visual role and announced control type.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the Windows WinUI “Settings > About” card to keep the app title+version string stable across localization re-application, while restyling the Website and Send feedback actions to appear as rounded secondary buttons.
Changes:
- Stop localizing
AboutVersionTextviaTagso localization refreshes don’t overwrite the programmatically composed"{app.title} {version}"text. - Add a
SupportLinkStyleforHyperlinkButtonand apply it to the Website and Feedback links.
File summaries
| File | Description |
|---|---|
| apps/windows/Sensitivity.WinUI/MainWindow.xaml | Removes localization tag from the version/title TextBlock; applies new style to support links. |
| apps/windows/Sensitivity.WinUI/App.xaml | Introduces SupportLinkStyle for button-like hyperlink styling. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+117
to
+119
| <StackPanel Orientation="Horizontal" Spacing="12"> | ||
| <HyperlinkButton Tag="about.website" NavigateUri="https://chromatic.hu" /> | ||
| <HyperlinkButton Tag="about.feedback" NavigateUri="mailto:feedback@chromatic.hu" /> | ||
| <HyperlinkButton Style="{StaticResource SupportLinkStyle}" Tag="about.website" NavigateUri="https://chromatic.hu" /> | ||
| <HyperlinkButton Style="{StaticResource SupportLinkStyle}" Tag="about.feedback" NavigateUri="mailto:feedback@chromatic.hu" /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the application version visible after localization refreshes and style Website and Send feedback as native rounded secondary buttons.