refactor(effects-manager): extract GLSL shaders to TypeScript modules (#886) - #973
Open
deveshbervar wants to merge 1 commit into
Open
refactor(effects-manager): extract GLSL shaders to TypeScript modules (#886)#973deveshbervar wants to merge 1 commit into
deveshbervar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2a of the refactoring proposed in #886.
Extracts the two inline GLSL shader strings from
effects-manager.tsinto dedicated TypeScript modules.What changed
New files:
shaders/hover-vertex.ts— vertex shader as TS default exportshaders/hover-fragment.ts— fragment shader as TS default exportModified:
effects-manager.ts— imports shaders from modules instead of defining them as inline class propertiesWhy TypeScript modules instead of .glsl files
Previous attempt (#933) used
.glslfiles withraw-loaderbut hit esbuild/Angular build pipeline issues in the Dockersmoke test. TypeScript modules work natively with all three build tools (webpack, esbuild, Jest) with zero configuration
changes.
Scope