[Chores] Addon 有关类和翻译的整理统一#6176
Conversation
|
有必要吗？？？？ |
|
我感觉不错，但不知道 Glavo 怎么想。 |
|
@3gf8jv4dv review 一下呗（ 我认为 addon 的中文译名还需要考虑一下，目前暂时是“游戏内容”，简称“内容” |
3gf8jv4dv
left a comment
3gf8jv4dv
left a comment
There was a problem hiding this comment.
addon.check_update 和 addon.dependency.* 清理一下吧，中英文之外的丢掉。
| addon.channel.alpha=預版 | ||
| addon.channel.beta=試版 | ||
| addon.channel.release=當版 | ||
| addon.check_update=檢改囊之新 |
对我而言，我大概会选择「游戏内容」或「游戏资源」。 |
Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
感觉还是有点怪。将一个资源包/模组文件称呼为“游戏内容”似乎不妥。而“游戏资源”容易跟assets混淆。 |
那我再想想。 参考下其他的话，Bedrock Edition 的 Add-on 现在简中称为「附加包」；Firefox 的 Add-on 在简中则称为「附加内容」。 |
这些用做总括性的词语都还可以。问题是如何称呼单个的模组文件/资源包文件等？感觉叫“附加内容”什么的一般反应不过来是模组/资源包/光影等等。 我觉得还不如就叫“文件”得了（ |
我觉得可以。 |
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/game/HMCLGameRepository.java # HMCL/src/main/java/org/jackhuang/hmcl/game/ModpackHelper.java # HMCL/src/main/java/org/jackhuang/hmcl/ui/download/DownloadPage.java # HMCL/src/main/java/org/jackhuang/hmcl/ui/export/ExportWizardProvider.java # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DownloadPage.java # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ResourcePackListPage.java # HMCL/src/main/java/org/jackhuang/hmcl/util/NativePatcher.java
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the codebase by renaming packages, classes, and localization keys from 'mod' to 'addon' (e.g., org.jackhuang.hmcl.mod to org.jackhuang.hmcl.addon). While the refactoring is comprehensive, several issues were identified: a potential unhandled NoSuchFileException in ModrinthRemoteAddonRepository due to file hashing being performed outside the try-catch block, missing translation keys in multiple non-English localization files, a non-thread-safe lazy initialization of BROKEN_DEPENDENCY in RemoteAddon, and an opportunity to modernize a switch statement in ModrinthRemoteAddonRepository using Java 14 switch expressions.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
# Conflicts: # HMCLCore/src/main/java/org/jackhuang/hmcl/mod/curse/CurseForgeRemoteModRepository.java
Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
4 participants
Uh oh!
There was an error while loading. Please reload this page.