test: set GIT_SSH_COMMAND in V2 remote-fetch test#38
Merged
Conversation
The test fakes GIT_SSH to intercept git fetch over SSH, but the host environment exports GIT_SSH_COMMAND (which takes priority over GIT_SSH), so git was using the real ssh binary and getting a real GitHub 404. Set GIT_SSH_COMMAND to the same fake script so the test is deterministic across environments. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test fakes GIT_SSH to intercept git fetch over SSH, but the host environment exports GIT_SSH_COMMAND (which takes priority over GIT_SSH), so git was using the real ssh binary and getting a real GitHub 404.
Set GIT_SSH_COMMAND to the same fake script so the test is deterministic across environments.