Skip to content

fix: resolve err shadow lint failures and bump eyrie submodule #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Patel230 merged 1 commit into from
Jun 18, 2026
Merged

fix: resolve err shadow lint failures and bump eyrie submodule #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion external/eyrie
Open in desktop
Submodule eyrie updated 57 files
+0 −12 catalog/catalog_test.go
+1 −5 catalog/fetch.go
+3 −15 catalog/model_tiers.go
+1 −25 catalog/model_tiers_test.go
+43 −86 catalog/xiaomi/http.go
+0 −9 client/adaptive_ratelimit.go
+109 −109 client/anthropic.go
+200 −0 client/anthropic_response_test.go
+17 −6 client/azure.go
+11 −2 client/batch.go
+20 −36 client/bedrock.go
+16 −13 client/cloud_providers_test.go
+14 −9 client/coalesce.go
+4 −6 client/compat_test.go
+5 −2 client/condenser.go
+20 −0 client/dynamic.go
+8 −2 client/embedding_client.go
+12 −3 client/fallback.go
+4 −6 client/fallback_test.go
+126 −3 client/gemini.go
+546 −0 client/gemini_stream_test.go
+3 −1 client/guardrails.go
+4 −6 client/guardrails_test.go
+5 −2 client/moderation.go
+4 −6 client/moderation_test.go
+40 −23 client/openai.go
+2 −2 client/openai_test.go
+35 −13 client/provider_errors.go
+111 −10 client/provider_errors_test.go
+22 −6 client/provider_registry.go
+76 −0 client/provider_registry_drift_test.go
+226 −0 client/provider_registry_test.go
+331 −0 client/provider_request_test.go
+12 −0 client/repeat_detector.go
+8 −0 client/retry.go
+27 −3 client/stream.go
+3 −1 client/stream_guardrails.go
+5 −8 client/stream_guardrails_test.go
+10 −33 client/vertex.go
+23 −40 config/credential/probe.go
+2 −2 credentials/health.go
+44 −17 credentials/keyring_platform.go
+155 −0 credentials/keyring_platform_test.go
+2 −2 credentials/lookup.go
+2 −0 docs/ARCHITECTURE.md
+4 −1 docs/guides/CREDENTIAL-SETUP-FLOW.md
+6 −3 docs/guides/DYNAMIC-MODEL-DISCOVERY.md
+378 −0 docs/plans/fix-critical-and-high-review.md
+95 −0 internal/probehttp/probehttp.go
+107 −0 internal/probehttp/probehttp_test.go
+8 −7 internal/shrink/shrink.go
+6 −0 router/circuitbreaker.go
+87 −0 router/circuitbreaker_test.go
+5 −8 router/router_test.go
+10 −7 types/errors.go
+2 −2 types/example_test.go
+2 −2 types/types_test.go
4 changes: 2 additions & 2 deletions internal/daemon/daemon.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,8 +410,8 @@ func (s *Server) handleChat(w http.ResponseWriter, r *http.Request) {
}

if req.MaxTurns > 0 {
if err := sess.SetMaxTurns(req.MaxTurns); err != nil {
slog.Error("invalid max turns", "err", err, "max_turns", req.MaxTurns)
if setErr := sess.SetMaxTurns(req.MaxTurns); setErr != nil {
slog.Error("invalid max turns", "err", setErr, "max_turns", req.MaxTurns)
writeJSON(w, http.StatusBadRequest, map[string]string{"error": "invalid max_turns"})
return
}
Expand Down
8 changes: 4 additions & 4 deletions internal/multiagent/worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ func EngineWorker(provider, model, systemPrompt string) WorkerFunc {
level = engine.AutonomyFull
}
sess.PermSvc().SetAutonomy(level)
if err := sess.SetMaxTurns(30); err != nil {
return nil, fmt.Errorf("set max turns: %w", err)
if setErr := sess.SetMaxTurns(30); setErr != nil {
return nil, fmt.Errorf("set max turns: %w", setErr)
}

// Auto-approve everything in mission workers
Expand Down Expand Up @@ -154,8 +154,8 @@ func ReadOnlyValidationWorker(provider, model, systemPrompt string) WorkerFunc {
level = engine.AutonomyFull
}
sess.PermSvc().SetAutonomy(level)
if err := sess.SetMaxTurns(30); err != nil {
return nil, fmt.Errorf("set max turns: %w", err)
if setErr := sess.SetMaxTurns(30); setErr != nil {
return nil, fmt.Errorf("set max turns: %w", setErr)
}
sess.PermissionFn = func(req engine.PermissionRequest) {
if req.Response != nil {
Expand Down
Loading