-
Notifications
You must be signed in to change notification settings - Fork 6.7k
feat(storage): update compose sample to support deleteSourceObjects option #14323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nidhiii-27
wants to merge
3
commits into
main
Choose a base branch
from
feat/python-compose-delete-sources
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,7 +20,13 @@ | |
| from google.cloud import storage | ||
|
|
||
|
|
||
| def compose_file(bucket_name, first_blob_name, second_blob_name, destination_blob_name): | ||
| def compose_file( | ||
| bucket_name, | ||
| first_blob_name, | ||
| second_blob_name, | ||
| destination_blob_name, | ||
| delete_source_objects=False, | ||
| ): | ||
| """Concatenate source blobs into destination blob.""" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| # bucket_name = "your-bucket-name" | ||
| # first_blob_name = "first-object-name" | ||
|
|
@@ -44,11 +50,22 @@ def compose_file(bucket_name, first_blob_name, second_blob_name, destination_blo | |
| # There is also an `if_source_generation_match` parameter, which is not used in this example. | ||
| destination_generation_match_precondition = 0 | ||
|
|
||
| destination.compose(sources, if_generation_match=destination_generation_match_precondition) | ||
| destination.compose( | ||
| sources, | ||
| if_generation_match=destination_generation_match_precondition, | ||
| delete_source_objects=delete_source_objects, | ||
| ) | ||
|
|
||
| deletion_message = ( | ||
| " and the source objects were deleted." if delete_source_objects else "." | ||
| ) | ||
| print( | ||
| "New composite object {} in the bucket {} was created by combining {} and {}".format( | ||
| destination_blob_name, bucket_name, first_blob_name, second_blob_name | ||
| "New composite object {} in the bucket {} was created by combining {} and {}{}".format( | ||
| destination_blob_name, | ||
| bucket_name, | ||
| first_blob_name, | ||
| second_blob_name, | ||
| deletion_message, | ||
| ) | ||
| ) | ||
| return destination | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
tempfile.NamedTemporaryFileis unnecessary here becausecompose_fileonly interacts with GCS blobs and does not read from or write to the local filesystem. We can simplify this by using a unique string for the destination blob name, avoiding the overhead of creating and deleting a temporary file on disk.