feat(storage): add dotnet deleteFolderRecursive sample#3340
Open
nidhiii-27 wants to merge 4 commits into
Open
Conversation
This adds a sample demonstrating how to recursively delete a folder in a hierarchical namespace bucket. Fixes: b/521168740 [Generated-by: AI]
- Update Google.Cloud.Storage.Control.V2 to 1.8.0 to resolve DeleteFolderRecursive method - Use fixture.GenerateName() instead of hardcoded folder name in tests - Assert with predicate instead of on the full Folder object to prevent flaky tests [Generated-by: AI]
nidhiii-27
added
ai-generated
product-auto-label
Bot
added
api: storage
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
…iveTest Add using System.Linq and replace invalid Assert.DoesNotContain predicate call with Assert.False(folders.Any(...)). [Generated-by: AI]
nidhiii-27
marked this pull request as ready for review
July 2, 2026 09:39
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
| StorageControlCreateFolderSample createSample = new StorageControlCreateFolderSample(); | ||
| var folder = createSample.StorageControlCreateFolder(_fixture.BucketNameHns, folderName); | ||
|
|
||
| StorageControlDeleteFolderRecursiveSample deleteSample = new StorageControlDeleteFolderRecursiveSample(); |
There was a problem hiding this comment.
Could you create a subfolder also and check when deleting the sample deletes both of them?
Resolved PR review feedback on recursive folder delete test by adding subfolder check. [Generated-by: AI]
krishnamd-jkp
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a .NET code sample demonstrating hierarchical namespace recursive folder delete.
Fixes: b/530059315