Skip to content

Run e2e on Android 16#6576

Draft
rahul-lohra wants to merge 6 commits into
developfrom
tests/rahullohra/android-17-e2e
Draft

Run e2e on Android 16#6576
rahul-lohra wants to merge 6 commits into
developfrom
tests/rahullohra/android-17-e2e

Conversation

@rahul-lohra

@rahul-lohra rahul-lohra commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Goal

Run e2e on Android 17

Implementation

Run e2e on Android 17

🎨 UI Changes

None

Testing

None

Summary by CodeRabbit

  • Tests
    • Updated Android end-to-end testing to run against Android API level 37.

@rahul-lohra rahul-lohra self-assigned this Jul 20, 2026
@rahul-lohra
rahul-lohra requested a review from a team as a code owner July 20, 2026 07:35
@rahul-lohra rahul-lohra added the pr:ci CI changes label Jul 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR checklist ❌

The following issues were detected:

  • Linked issue missing. Add a Linear ticket reference (e.g. AND-123, Closes AND-123, or a https://linear.app/... link) or a GitHub issue (Closes #123) to the PR description.

What we check

  1. Title is concise (5–18 words) unless labeled pr:ignore-for-release.
  2. At least one pr: label exists (e.g., pr:bug, pr:new-feature).
  3. Sections ### Goal, ### Implementation, and ### Testing contain content. Bot-authored PRs are exempt.
  4. PR description references an issue (Linear ticket like AND-123, a Linear URL, or a GitHub Closes #N). Bot-authored PRs are exempt.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The E2E compose-test workflow now runs its Android emulator at API level 37 instead of 34.

Changes

E2E emulator configuration

Layer / File(s) Summary
Update emulator API level
.github/workflows/e2e-test.yml
Sets ANDROID_API_LEVEL to 37, which is passed to the emulator runner.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: peter-matkovski

Poem

A bunny hops where emulators gleam,
API thirty-seven joins the stream.
Compose tests run, the carrots sway,
Green checks may guide the testing day.
Hop, hop—configuration finds its way!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title says Android 16, but the change and description target Android 17, so it misstates the main update. Update the title to match the actual change, for example: 'Run e2e on Android 17'.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The core Goal, Implementation, UI Changes, and Testing sections are present and aligned with the template.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tests/rahullohra/android-17-e2e

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 5.95 MB 5.95 MB 0.00 MB 🟢
stream-chat-android-ui-components 11.21 MB 11.21 MB 0.00 MB 🟢
stream-chat-android-compose 12.69 MB 12.69 MB 0.00 MB 🟢

@andremion andremion left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for setting this up. The CI failures here are not test failures, the emulator never boots. Details in the inline comment.

The same issue affects the cron workflow after #6575 was merged: the android_api_level: 37 leg in e2e-test-cron.yml will fail the same way every night, and it will trigger the nightly Slack alert each time. The 36 leg is fine (platforms;android-36 and system-images;android-36;default;x86_64 both exist). Could you include the cron fix in this PR too, or in a small follow-up? Since the matrix legs need different targets, something like:

matrix:
  include:
    - android_api_level: "37.0"
      target: google_apis_ps16k
    - android_api_level: 36
    ...

and in the emulator step:

          target: ${{ matrix.target || 'default' }}

Comment thread .github/workflows/e2e-test.yml Outdated
fail-fast: false
env:
ANDROID_API_LEVEL: 34
ANDROID_API_LEVEL: 37

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is why the three Test compose shards fail in ~30s. There is no platforms;android-37 package in the SDK repository. Android 17 uses the new major.minor naming, so the available packages are platforms;android-37.0 and platforms;android-37.1.

There is a second problem behind it: the step does not set target:, so android-emulator-runner defaults to default (AOSP). No default system image exists for 37 at all. The only x86_64 images are google_apis_ps16k and google_apis_playstore_ps16k.

Could you change it to this?

env:
  ANDROID_API_LEVEL: "37.0"

and add the target to the emulator step:

          api-level: ${{ env.ANDROID_API_LEVEL }}
          target: google_apis_ps16k

That resolves to platforms;android-37.0 and system-images;android-37.0;google_apis_ps16k;x86_64, both present in the stable channel. One caveat: the 37 images are 16 KB page-size builds, so we only learn from a run whether the tests pass on them.

@sonarqubecloud

Copy link
Copy Markdown

@rahul-lohra rahul-lohra changed the title [Won't Merge] Run e2e on Android 17 Run e2e on Android 16 Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:ci CI changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants