Run e2e on Android 16#6576
Conversation
PR checklist ❌The following issues were detected:
What we check
|
WalkthroughThe E2E compose-test workflow now runs its Android emulator at API level 37 instead of 34. ChangesE2E emulator configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SDK Size Comparison 📏
|
andremion
left a comment
There was a problem hiding this comment.
Thanks for setting this up. The CI failures here are not test failures, the emulator never boots. Details in the inline comment.
The same issue affects the cron workflow after #6575 was merged: the android_api_level: 37 leg in e2e-test-cron.yml will fail the same way every night, and it will trigger the nightly Slack alert each time. The 36 leg is fine (platforms;android-36 and system-images;android-36;default;x86_64 both exist). Could you include the cron fix in this PR too, or in a small follow-up? Since the matrix legs need different targets, something like:
matrix:
include:
- android_api_level: "37.0"
target: google_apis_ps16k
- android_api_level: 36
...and in the emulator step:
target: ${{ matrix.target || 'default' }}| fail-fast: false | ||
| env: | ||
| ANDROID_API_LEVEL: 34 | ||
| ANDROID_API_LEVEL: 37 |
There was a problem hiding this comment.
This is why the three Test compose shards fail in ~30s. There is no platforms;android-37 package in the SDK repository. Android 17 uses the new major.minor naming, so the available packages are platforms;android-37.0 and platforms;android-37.1.
There is a second problem behind it: the step does not set target:, so android-emulator-runner defaults to default (AOSP). No default system image exists for 37 at all. The only x86_64 images are google_apis_ps16k and google_apis_playstore_ps16k.
Could you change it to this?
env:
ANDROID_API_LEVEL: "37.0"and add the target to the emulator step:
api-level: ${{ env.ANDROID_API_LEVEL }}
target: google_apis_ps16kThat resolves to platforms;android-37.0 and system-images;android-37.0;google_apis_ps16k;x86_64, both present in the stable channel. One caveat: the 37 images are 16 KB page-size builds, so we only learn from a run whether the tests pass on them.
|



Goal
Run e2e on Android 17
Implementation
Run e2e on Android 17
🎨 UI Changes
None
Testing
None
Summary by CodeRabbit